fix: add ci for test, lint, format and typecheck #72
Conversation
lstocchi
force-pushed
the
i38
branch
2 times, most recently
from
1eee17a to
96f7fb5
Compare
|
🚀 |
Signed-off-by: lstocchi <[email protected]>
|
It seems you will have to run this command locally, to get some files correctly formatted (beware, files will be modified in place): |
shared package has an issue. shared module should not depends on 'web' library because backend importing these classes is a pure Node.JS module so some classes of shared should be only on frontend fix a test returning a string and not a promise
chore: some workaround for podman-desktop/api
Signed-off-by: lstocchi <[email protected]>
packages/frontend/package.json
Outdated
| "svelte": "4.2.8", | ||
| "svelte-preprocess": "^5.1.3", | ||
| "tailwindcss": "^3.4.0", | ||
| "postcss": "^8.4.33", | ||
| "postcss-load-config": "^5.0.2" | ||
| "postcss-load-config": "^5.0.2" |
There was a problem hiding this comment.
it looks like the file is not formatted/sorted (usually it is ordered in alphabetical order) and there is an extra space here
There was a problem hiding this comment.
how do you sort it automatically? Is there any npm package? 🤔
There was a problem hiding this comment.
I think it is done when you run yarn add <package>
There was a problem hiding this comment.
I was hoping we could add some script so that if someone copy/paste an entry it is sorted anyway
There was a problem hiding this comment.
(anyway it's not a requested change)
There was a problem hiding this comment.
cool, i'm going to add it in a follow-up PR so i don't block @feloy
for the moment i fixed it manually
Signed-off-by: lstocchi <[email protected]>
* add option for config file in playground * Update playground/README.md Co-authored-by: Sébastien Han <[email protected]> --------- Co-authored-by: Sébastien Han <[email protected]>
No description provided.